Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Store the heartbeat data in the task and node tables #164

Merged
merged 18 commits into from
Oct 20, 2020

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Oct 16, 2020

Summary of the Pull Request

Storing the heartbeat data in the task and node tables

PR Checklist

  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@chkeita chkeita force-pushed the chkeita/move_heartbeat branch from b12325a to 0da31d3 Compare October 16, 2020 01:40
@chkeita chkeita force-pushed the chkeita/move_heartbeat branch from 6f43611 to 61f40d2 Compare October 16, 2020 01:58
@chkeita chkeita marked this pull request as ready for review October 16, 2020 22:52
src/api-service/__app__/onefuzzlib/pools.py Outdated Show resolved Hide resolved
src/api-service/__app__/onefuzzlib/tasks/main.py Outdated Show resolved Hide resolved
@bmc-msft bmc-msft changed the title Chkeita/move heartbeat Store the heartbeat data in the task and node tables Oct 17, 2020
bmc-msft
bmc-msft previously approved these changes Oct 19, 2020
@bmc-msft bmc-msft dismissed their stale review October 19, 2020 18:21

During testing, found node heartbeats are not being saved

@bmc-msft bmc-msft merged commit 178537d into microsoft:main Oct 20, 2020
@chkeita chkeita deleted the chkeita/move_heartbeat branch March 31, 2021 21:52
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants